[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU blo
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend |
|
Date: |
Tue, 22 Jul 2014 13:35:20 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote:
> + xseg_set_req_data(s->xseg, req, reqdata);
> + if (op == ARCHIP_OP_WRITE) {
> + data = xseg_get_data(s->xseg, req);
> + if (!data) {
> + archipelagolog("Cannot get XSEG data\n");
> + goto err_exit;
> + }
> + memcpy(data, aio_cb->buffer + bufidx, count);
> + }
Can you avoid ->buffer and use iov_to_buf() or qemu_iovec_to_buf()
instead?
pgpV5KclnROKB.pgp
Description: PGP signature