Re: [Qemu-devel] [PATCH v2 2/5] block: vdi - use block layer ops in vdi_create, instead of posix calls

[Max Reitz]

On 21.07.2014 21:52, Jeff Cody wrote:
> Use the block layer to create, and write to, the image file in the
> VDI .bdrv_create() operation.
>
> This has a couple of benefits: Images can now be created over protocols,
> and hacks such as NOCOW are not needed in the image format driver, and
> the underlying file protocol appropriate for the host OS can be relied

This sounds a bit strange to me, but I don't know if it's wrong.

> upon.
>
> Also some minor cleanup for error handling.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>   block/vdi.c | 68 ++++++++++++++++++++++++++-----------------------------------
>   1 file changed, 29 insertions(+), 39 deletions(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 197bd77..5fd9d5f 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -681,7 +681,6 @@ static int vdi_co_write(BlockDriverState *bs,
>   

Anyway:

Reviewed-by: Max Reitz <address@hidden>