[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.1] docs: document remaining QMP events
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.1] docs: document remaining QMP events |
Date: |
Wed, 23 Jul 2014 05:51:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/23/2014 01:25 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Commit dfab4892 restored this file, but did not address any of the
>> grammar problems that had been fixed in passing when moving events
>> out of this file. There are also a couple events that were
>> undocumented since introduction, and one that had been added only
>> in the time that this file was temporarily deleted.
>> -SPICE_CONNECTED, SPICE_DISCONNECTED
>> ------------------------------------
>> +SPICE_CONNECTED
>> +---------------
>>
>> -Emitted when a SPICE client connects or disconnects.
>> +Emitted when a SPICE client connects.
>
> Wording doesn't match qapi-event.json exactly. I doubt we care.
Not the only place where they don't match. And I personally don't care :)
>>
>> +SPICE_INITIALIZED
>
> Another SPICE_INITIALIZED? Do you mean SPICE_MIGRATE_COMPLETED?
>
Copy-and-paste strikes again. Yes, I'll fix that.
>
> Assuming you do mean SPICE_MIGRATE_COMPLETED: list is complete now.
>
> Would you mind splitting this patch?
>
> * Either one patch per undocumented event (if you want to be nice to
> downstreams cherry-picking events), or one patch for all of them.
>
> * One patch for the rest. Or if you feel generous, two: one for the
> grammar fixes, one for the spice split.
v2 coming up as a full series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature