Re: [Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation

[Le Tan]

Hi Stefan,

2014-07-24 4:29 GMT+08:00 Stefan Weil <address@hidden>:
> Am 22.07.2014 17:47, schrieb Le Tan:
>> Add support for emulating Intel IOMMU according to the VT-d specification for
>> the q35 chipset machine. Implement the logic for DMAR (DMA remapping) without
>> PASID support. Use register-based invalidation for context-cache invalidation
>> and IOTLB invalidation.
>> Basic fault reporting and caching are not implemented yet.
>>
>> Signed-off-by: Le Tan <address@hidden>
>> ---
>>  hw/i386/Makefile.objs         |    1 +
>>  hw/i386/intel_iommu.c         | 1139 
>> +++++++++++++++++++++++++++++++++++++++++
>>  include/hw/i386/intel_iommu.h |  350 +++++++++++++
>>  3 files changed, 1490 insertions(+)
>>  create mode 100644 hw/i386/intel_iommu.c
>>  create mode 100644 include/hw/i386/intel_iommu.h
>>
> [...]
>> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
>> new file mode 100644
>> index 0000000..3ba0e1e
>> --- /dev/null
>> +++ b/hw/i386/intel_iommu.c
>> @@ -0,0 +1,1139 @@
>> +/*
>> + * QEMU emulation of an Intel IOMMU (VT-d)
>> + *   (DMA Remapping device)
>> + *
>> + * Copyright (c) 2013 Knut Omang, Oracle <address@hidden>
>> + * Copyright (C) 2014 Le Tan, <address@hidden>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> +
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> +
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  
>> USA
>> + */
>> +
>
> I suggest replacing the FSF address here (and in other files) by the URL:
>
>  * You should have received a copy of the GNU General Public License along
>  * with this program; if not, see <http://www.gnu.org/licenses/>.
>
> This is the standard used for most GPL text in QEMU source files.

Get it. I copied it from the Linux kernel tree.
Thanks very much!

> Regards
> Stefan W.
>

Regards,
Le