[Qemu-devel] [PATCH v2 0/4] libqtest: solve QEMU process cleanup problem

[Stefan Hajnoczi]

v2:
 * Added qemu_system_shutdown_force() API [Peter]

Test cases are supposed to clean up even if they fail.  Historically libqtest
has leaked QEMU processes and files.  This caused annoyances and buildbot
failures so it was gradually fixed.

The solution we have for terminating the QEMU process if the test case fails
was not very satisfactory.  A SIGABRT handler in the test case sends SIGTERM to
QEMU.  This only works if the test case receives SIGABRT, not other ways in
which it could die.  The approach is ugly because it installs a global signal
handler although libqtest is supposed to support multiple simultaneous
instances.

This patch series adds the new -chardev exit-on-eof option.  QEMU will
terminate if the socket/pipe/stdio receives EOF.  That happens when the test
case process terminates for any reason.  By adding this option to -chardev we
can use it with both -qtest and -qmp.

Stefan Hajnoczi (4):
  vl: add qemu_system_shutdown_force()
  libqemustub: add qemu_system_shutdown_force()
  qemu-char: add -chardev exit-on-eof option
  libqtest: use -chardev exit-on-eof to clean up QEMU

 include/sysemu/char.h   |  1 +
 include/sysemu/sysemu.h |  2 +-
 qapi-schema.json        | 23 ++++++++++++++++-------
 qemu-char.c             | 33 +++++++++++++++++++++++++++------
 qemu-options.hx         | 19 +++++++++++++------
 qmp.c                   |  3 +--
 stubs/Makefile.objs     |  1 +
 stubs/shutdown.c        |  5 +++++
 tests/libqtest.c        | 48 +++---------------------------------------------
 ui/sdl.c                |  3 +--
 ui/sdl2.c               |  6 ++----
 vl.c                    | 11 ++++++++---
 12 files changed, 79 insertions(+), 76 deletions(-)
 create mode 100644 stubs/shutdown.c

-- 
1.9.3