Re: [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization

[Marc Marí]

El Fri, 25 Jul 2014 16:19:41 +0100
Stefan Hajnoczi <address@hidden> escribió:
> On Thu, Jul 24, 2014 at 08:31:00PM +0200, Marc Marí wrote:
> > +static uint32_t qvirtio_pci_get_features(QVirtioDevice *d)
> > +{
> > +    QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> > +    return qpci_io_readl(dev->pdev, dev->addr +
> > QVIRTIO_DEVICE_FEATURES); +}
> 
> Unused?  If it's unused, then it's untested.

Yes, moved to the other patch for v2

> 
> > +
> > +static uint8_t qvirtio_pci_get_status(QVirtioDevice *d)
> > +{
> > +    QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> > +    return qpci_io_readb(dev->pdev, dev->addr +
> > QVIRTIO_DEVICE_STATUS); +}
> 
> Unused?

Used in virtio.c (qvirtio_reset / qvirtio_set_acknowledge /
qvirtio_set_driver).

 
> > +
> > +static void qvirtio_pci_set_status(QVirtioDevice *d, uint8_t val)
> > +{
> > +    QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> > +    qpci_io_writeb(dev->pdev, dev->addr + QVIRTIO_DEVICE_STATUS,
> > val);
> 
> Unused?

Also in virtio.c

> 
> > @@ -73,3 +97,11 @@ QVirtioPCIDevice
> > *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type) 
> >      return dev;
> >  }
> > +
> > +void qvirtio_pci_enable_device(QVirtioPCIDevice *d)
> > +{
> > +    qpci_device_enable(d->pdev);
> > +    d->addr = qpci_iomap(d->pdev, 0);
> > +    g_assert(d->addr != NULL);
> > +}
> 
> Where is qpci_iounmap() called to clean up?

Missed. Also, it is unimplemented.
Marc