[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak |
Date: |
Fri, 25 Jul 2014 20:07:40 +0200 |
As soon as options is set in img_amend(), it needs to be freed before
the function returns. This leak is rather insignifcant, as qemu-img will
exit subsequently anyway, but there's no point in not fixing it.
Signed-off-by: Max Reitz <address@hidden>
---
qemu-img.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index a06f425..d73a68a 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2809,7 +2809,9 @@ static int img_amend(int argc, char **argv)
}
if (optind != argc - 1) {
- error_exit("Expecting one image file name");
+ error_report("Expecting one image file name");
+ ret = -1;
+ goto out;
}
flags = BDRV_O_FLAGS | BDRV_O_RDWR;
--
2.0.1
- [Qemu-devel] [PATCH 0/8] block/qcow2: Improve (?) zero cluster expansion, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 2/8] qemu-img: Add progress output for amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak,
Max Reitz <=
- [Qemu-devel] [PATCH 4/8] block/qcow2: Make get_refcount() global, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 6/8] block/qcow2: Simplify shared L2 handling in amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 7/8] block/qcow2: Speed up zero cluster expansion, Max Reitz, 2014/07/25