[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmst
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate |
Date: |
Mon, 28 Jul 2014 12:12:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto:
>>> > > + VMSTATE_TIMER_V(timer, RTL8139State, 5),
>> >
>> > timer need not be migrated, because it is reinstated by rtl8139_post_load.
>> >
> That's true for normal execution.
> In replay execution mode post_load can be called before cached virtual clock
> values are loaded. This may cause invalid setting of the timer and raising
> an IRQ which didn't happen in record mode.
> I will update this patch to fix post_load function and avoid this
> non-deterministic behavior.
This is what worries me of this series. These invariants are not
documented anywhere, and people will break them unless you add
assertions that also hold in normal mode.
Paolo
[Qemu-devel] [RFC PATCH v2 09/49] pckbd: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 42/49] replay: network packets record/replay, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 44/49] replay: serial port, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 43/49] replay: audio data record/replay, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 45/49] replay: USB passthrough, Pavel Dovgalyuk, 2014/07/17
[Qemu-devel] [RFC PATCH v2 46/49] replay: replay_info command, Pavel Dovgalyuk, 2014/07/17