Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

[Laszlo Ersek]

On 07/29/14 12:39, Paolo Bonzini wrote:
> Il 29/07/2014 12:31, Michael S. Tsirkin ha scritto:
>>> For patch "piix: set legacy table size for 1.7": didn't Igor say
>>> something that such a migration wouldn't work anyway? I could be
>>> remembering wrong.
>>
>> I don't recall this, but if there are more bug we could just
>> fix them too.
> 
> You have to choose between a "-M pc-i440fx-1.7" that migrates from 1.7
> to 2.1, and one that migrates from 2.0 to 2.1.
> 
> - to make 1.7->2.1 work: you need both Igor's patch ("generate AML
> only...") and "piix: set legacy table size for 1.7".  All configurations
> will work, including those with PCI bridges.
> 
> - to make 2.0->2.1 work (with "-M pc-i440fx-1.7"): you need to omit
> "piix: set legacy table size for 1.7", and configurations with PCI
> bridges remain broken.  Igor's patch is not needed, because it only
> affects configurations with PCI bridges.
> 
> mst prefers the first one, and he changed my view on that too.  And he
> noticed that with "piix: set legacy table size for 1.7" more things just
> work, so it's better to include it.

I see. Thanks.

> 1  acd727e acpi-dsdt: procedurally generate _PRT
> 2  07fb617 pc: hack for migration compatibility from QEMU 2.0

These already have my R-b.

> 3  3d5061f bios-tables-test: fix ASL normalization false positive

Just gave my R-b in this thread.

> 4  82631f6 pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug 
> is disabled

Acked-by: Laszlo Ersek <address@hidden>

> 5  1cffcf8 acpi-build: minor code cleanup

Typos in the commit message should be fixed. With those changes,
Reviewed-by: Laszlo Ersek <address@hidden>

> 6  3200ac6 pc: future-proof migration-compatibility of ACPI tables

Has my R-b already.

> 7  004af2c acpi-build: tweak acpi migration limits

Reviewed-by: Laszlo Ersek <address@hidden>

> 8  5c35a24 piix: set legacy table size for 1.7

Acked-by: Laszlo Ersek <address@hidden>

Laszlo