[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info |
Date: |
Tue, 29 Jul 2014 06:45:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/29/2014 01:18 AM, Chunyan Liu wrote:
> Add nocow info in 'qemu-img info' output to show whether the file
> currently has NOCOW flag set or not.
>
> Signed-off-by: Chunyan Liu <address@hidden>
> Acked-by: Eric Blake <address@hidden>
Actually, this should be Reviewed-by, not Acked-by. My understanding is
that "Reviewed-by" is stronger (I actually read through the patch, and
looked for possible problems) while "Acked-by" is weaker (a maintainer
stating that the work is taken in on the basis of third-party reviews
without actually reviewing the patch itself).
> ---
> Resend for QEMU 2.2. Change json version comment.
>
> block/qapi.c | 25 +++++++++++++++++++++++++
> qapi/block-core.json | 5 ++++-
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature