[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vms
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process |
Date: |
Tue, 29 Jul 2014 13:42:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/29/2014 12:04 PM, Sanidhya Kashyap wrote:
>>> +void qmp_test_vmstates_set_period(int64_t period, Error **errp)
>>> +{ + VMStateLogState *v = vmstate_current_state(); + if
>>> (period < TEST_VMSTATE_MIN_INTERVAL_MS || + period >
>>> TEST_VMSTATE_MAX_INTERVAL_MS) { + error_setg(errp, "sleep
>>> interval (period) value must be " + "in the
>>> defined range [%d, %d](ms)\n", +
>>> TEST_VMSTATE_MIN_INTERVAL_MS, TEST_VMSTATE_MAX_INTERVAL_MS); +
>>> return; + } + v->period = period; +}
Uggh, your mailer clobbered whitespace when replying :(
>
>> This looks like it takes effect whether or not a vmstate test is
>> underway. Does this impact the default of the next vmstate test
>> to
>
> Yes
>
>> start, in the case where that command doesn't supply a value for
>> period but relies on the default?
>
> No, it does not.
Then it may be worth fixing the command to error out if there is no
active vmstate test underway, instead of changing a value that has no
effect.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature