[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] runner: Make a copy of a test image for des
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] runner: Make a copy of a test image for destructive test commands |
Date: |
Wed, 30 Jul 2014 16:49:22 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 07/24 16:32, Maria Kustova wrote:
> Signed-off-by: Maria Kustova <address@hidden>
> ---
> tests/image-fuzzer/runner/runner.py | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/tests/image-fuzzer/runner/runner.py
> b/tests/image-fuzzer/runner/runner.py
> index 3e9e65d..6ec40a4 100755
> --- a/tests/image-fuzzer/runner/runner.py
> +++ b/tests/image-fuzzer/runner/runner.py
> @@ -21,8 +21,8 @@
> import sys, os, signal
> import subprocess
> import random
> +import shutil
> from itertools import count
> -from shutil import rmtree
> import getopt
> try:
> import json
> @@ -107,7 +107,9 @@ class TestEnv(object):
> 'discard $off $len'],
> ['qemu-io', '$test_img', '-c',
> 'truncate $off']]
> - for fmt in ['raw', 'vmdk', 'vdi', 'cow', 'qcow2', 'file',
> + # VMDK format is skipped because such conversion requires
> + # a pregenerated vmdk file
> + for fmt in ['raw', 'vdi', 'cow', 'qcow2', 'file',
How exactly doesn't VMDK work? I think qemu-img can handle it for you, and no
"pregenerated vmdk file" is needed.
> 'qed', 'vpc']:
> self.commands.append(
> ['qemu-img', 'convert', '-f', 'qcow2', '-O', fmt,
> @@ -146,7 +148,7 @@ class TestEnv(object):
> 'file', 'qed', 'vpc'])
> backing_file_name = 'backing_img.' + backing_file_fmt
> # Size of the backing file varies from 1 to 10 MB
> - backing_file_size = random.randint(1, 10)*(1 << 20)
> + backing_file_size = random.randint(1, 10) * (1 << 20)
This is not related to this patch.
Fam