Re: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize

[Stefan Hajnoczi]

On Tue, Jul 29, 2014 at 07:28:56PM -0400, John Snow wrote:
> My previous commit, 713e8a10, did not address the fact that
> the error checking pathways do not attempt to call
> virtio_cleanup and thus can leak memory in hotplug scenarios.
> 
> This patchset shuffles around the error checking so it does not
> need to perform said cleanup, and changes the error functions
> from error_set to error_setg.
> 
> John Snow (2):
>   virtio-rng: Move error-checking forward to prevent memory leak
>   virtio-rng: replace error_set calls with error_setg
> 
>  hw/virtio/virtio-rng.c | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpuVnmx07pud.pgp
Description: PGP signature