[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH target-arm v1 1/1] sd: sdhci: Fix ADMA dma_memory_re
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH target-arm v1 1/1] sd: sdhci: Fix ADMA dma_memory_read access |
Date: |
Wed, 30 Jul 2014 20:11:06 -0700 |
This dma_memory_read was giving too big a size when begin was non-zero.
This could cause segfaults in some circumstances. Fix.
Signed-off-by: Peter Crosthwaite <address@hidden>
---
hw/sd/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index b5a9eee..f9fe700 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -702,7 +702,8 @@ static void sdhci_do_adma(SDHCIState *s)
length -= block_size - begin;
}
dma_memory_read(&address_space_memory, dscr.addr,
- &s->fifo_buffer[begin], s->data_count);
+ &s->fifo_buffer[begin],
+ s->data_count - begin);
dscr.addr += s->data_count - begin;
if (s->data_count == block_size) {
for (n = 0; n < block_size; n++) {
--
2.0.1.1.gfbfc394
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH target-arm v1 1/1] sd: sdhci: Fix ADMA dma_memory_read access,
Peter Crosthwaite <=