[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_i
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_io |
Date: |
Thu, 31 Jul 2014 14:04:35 +1000 |
On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini <address@hidden> wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/core/sysbus.c | 5 -----
> include/hw/sysbus.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> index f4e760d..414e2a1 100644
> --- a/hw/core/sysbus.c
> +++ b/hw/core/sysbus.c
> @@ -242,11 +242,6 @@ void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
> memory_region_add_subregion(get_system_io(), addr, mem);
> }
>
> -void sysbus_del_io(SysBusDevice *dev, MemoryRegion *mem)
> -{
> - memory_region_del_subregion(get_system_io(), mem);
> -}
> -
> MemoryRegion *sysbus_address_space(SysBusDevice *dev)
> {
> return get_system_memory();
> diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
> index f5aaa05..0bb91a8 100644
> --- a/include/hw/sysbus.h
> +++ b/include/hw/sysbus.h
> @@ -71,7 +71,6 @@ void sysbus_mmio_map_overlap(SysBusDevice *dev, int n,
> hwaddr addr,
> int priority);
> void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
> MemoryRegion *mem);
> -void sysbus_del_io(SysBusDevice *dev, MemoryRegion *mem);
> MemoryRegion *sysbus_address_space(SysBusDevice *dev);
>
> /* Legacy helper function for creating devices. */
> --
> 1.8.3.1
>
>
>
- [Qemu-devel] [PATCH for-2.2 0/9] memory: remove memory_region_destroy, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 1/9] qom: object: delete properties before calling instance_finalize, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 2/9] qom: object: move unparenting to the child property's release callback, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_io, Paolo Bonzini, 2014/07/30
- Re: [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_io,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in cleanup functions, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 7/9] memory: convert memory_region_destroy to object_unparent, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 8/9] memory: remove memory_region_destroy, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback, Paolo Bonzini, 2014/07/30