[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idio
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style |
Date: |
Thu, 31 Jul 2014 13:39:59 +0100 |
On 31 July 2014 13:28, <address@hidden> wrote:
> From: Gonglei <address@hidden>
>
> Gonglei (7):
> usb: a trivial code change for more idiomatic writing style
> audio: a trivial code change for more idiomatic writing style
> isa-bus: a trivial code change for more idiomatic writing style
> a trivial code change for more idiomatic writing style
> spice: a trivial code change for more idiomatic writing style
> vl: a trivial code change for more idiomatic writing style
> vmxnet3: a trivial code change for more idiomatic writing style
Hi. I think we could make the commit messages here
a bit more specific:
===
$WHATEVER: don't use 'Yoda conditions'
'Yoda conditions' are not part of idiomatic QEMU coding
style, so rewrite them in the more usual order.
===
thanks
-- PMM
- [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 1/7] usb: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 6/7] vl: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 7/7] vmxnet3: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 5/7] spice: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 4/7] a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 3/7] isa-bus: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH 2/7] audio: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style,
Peter Maydell <=