[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate |
Date: |
Thu, 31 Jul 2014 15:01:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 31/07/2014 14:54, Pavel Dovgalyuk ha scritto:
> +static int apic_pre_load(void *opaque)
> +{
> + APICCommonState *s = APIC_COMMON(opaque);
> + s->sipi_vector = 0;
> + s->wait_for_sipi = 0;
> + s->vapic_paddr = 0;
> + return 0;
Is this necessary? Or does reset already do that?
> +}
> +
> static void apic_dispatch_pre_save(void *opaque)
> {
> APICCommonState *s = APIC_COMMON(opaque);
> @@ -345,12 +354,46 @@ static int apic_dispatch_post_load(void *opaque, int
> version_id)
> return 0;
> }
>
> +static bool apic_common_sipi_needed(void *opaque)
> +{
> + APICCommonState *s = APIC_COMMON(opaque);
> + return s->wait_for_sipi != 0;
> +}
> +
> +static const VMStateDescription vmstate_apic_common_sipi = {
> + .name = "apic_sipi",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_INT32(sipi_vector, APICCommonState),
> + VMSTATE_INT32(wait_for_sipi, APICCommonState),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> +static bool apic_common_vapic_paddr_needed(void *opaque)
> +{
> + APICCommonState *s = APIC_COMMON(opaque);
> + return s->vapic_paddr != 0;
> +}
> +
> +static const VMStateDescription vmstate_apic_common_vapic_paddr = {
> + .name = "apic_vapic_paddr",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT64(vapic_paddr, APICCommonState),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> static const VMStateDescription vmstate_apic_common = {
> .name = "apic",
> - .version_id = 3,
> + .version_id = 4,
You know what I'm going to say. :)
Paolo
- [Qemu-devel] [RFC PATCH v3 00/49] Deterministic replay and reverse execution, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 01/49] acpi: accurate overflow check, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 02/49] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 03/49] pcspk: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 04/49] fdc: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 05/49] parallel: adding vmstate for save/restore, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 06/49] serial: fixing vmstate for save/restore, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate, Pavel Dovgalyuk, 2014/07/31
- Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v3 08/49] hpet: fixing saving and loading process, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 09/49] pckbd: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 11/49] piix: do not raise irq while loading vmstate, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 12/49] mc146818rtc: add missed field to vmstate, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 13/49] pl031: add missed field to vmstate, Pavel Dovgalyuk, 2014/07/31
- [Qemu-devel] [RFC PATCH v3 14/49] ide pci: reset status field before loading the vmstate, Pavel Dovgalyuk, 2014/07/31