Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

[Gonglei (Arei)]

Hi,

> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic 
> writing
> style
> 
> Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> > Hi,
> >
> >> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> >> style
> >>
> >> On 07/31/2014 08:32 PM, address@hidden wrote:
> >>> From: Gonglei <address@hidden>
> >>>
> >>> Signed-off-by: Gonglei <address@hidden>
> >>> ---
> >>>  hw/usb/dev-audio.c | 2 +-
> >>>  hw/usb/dev-mtp.c   | 4 ++--
> >>>  hw/usb/hcd-ehci.c  | 2 +-
> >>>  3 files changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
> >>> index bfebfe9..988f6cc 100644
> >>> --- a/hw/usb/dev-audio.c
> >>> +++ b/hw/usb/dev-audio.c
> >>> @@ -371,7 +371,7 @@ static void output_callback(void *opaque, int avail)
> >>>              return;
> >>>          }
> >>>          data = streambuf_get(&s->out.buf);
> >>> -        if (NULL == data) {
> >>> +        if (data == NULL) {
> >>
> >> Wouldn't it be even more idiomatic as:
> >>
> >> if (!data) {
> >>
> >> Probably applies throughout your series.
> >>
> > OK, will do. Thanks!
> 
> Not so quick! You are free to use that in your patches, but please don't
> change all code that way without the author's consent. Just like "equals
> null" is a natural English way of reading, compared to "null equals
> something", "not null" reads like a boolean expression to me, and even
> worse while all valid C, "not strcmp" leads to mind-boggling inverted
> logic...
> 
OK, I will wait for other maintainer's comments. Thanks!
Our focus is just on doing not use 'Yoda conditions' in QEMU.

> Regards,
> Andreas
> 
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Best regards,
-Gonglei