Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases

[Slava Pestov]

Why are you guys merging requests in qemu at all? Just submit them to the kernel and let the kernel do it.

On Wed, Jul 30, 2014 at 1:11 AM, Stefan Hajnoczi <address@hidden> wrote:

On Tue, Jul 29, 2014 at 4:11 PM, Eric Blake <address@hidden> wrote:
> On 07/29/2014 06:41 AM, Stefan Hajnoczi wrote:
>> This test case covers the basic bdrv_aio_multiwrite() scenarios:
>> 1. Single request
>> 2. Sequential requests
>> 3. Overlapping requests
>> 4. Disjoint requests
>>
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>> ---
>
>> +echo
>> +echo "== Overlapping requests =="
>> +_make_test_img $size
>> +$QEMU_IO -c "multiwrite 0 4k ; 1k 2k" "$TEST_IMG" | _filter_qemu_io
>> +
>
> This only tests superset overlap:
>
> AAAA
>  BB
>
> Wouldn't it be good to also test head overlap, tail overlap, and subset
> overlap, as in:
>
> AAA
>   BB
>
>  AAA
> BB
>
>  AA
> BBBB

Sure, I can add more test cases in v2.

Stefan