qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] query-memdev: fix potential memory leaks


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH 1/3] query-memdev: fix potential memory leaks
Date: Fri, 1 Aug 2014 23:08:26 +1000

On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan <address@hidden> wrote:
> Signed-off-by: Chen Fan <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  numa.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/numa.c b/numa.c
> index 7bf7834..a2b4bca 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -318,10 +318,11 @@ void memory_region_allocate_system_memory(MemoryRegion 
> *mr, Object *owner,
>  static int query_memdev(Object *obj, void *opaque)
>  {
>      MemdevList **list = opaque;
> +    MemdevList *m = NULL;
>      Error *err = NULL;
>
>      if (object_dynamic_cast(obj, TYPE_MEMORY_BACKEND)) {
> -        MemdevList *m = g_malloc0(sizeof(*m));
> +        m = g_malloc0(sizeof(*m));
>
>          m->value = g_malloc0(sizeof(*m->value));
>
> @@ -369,6 +370,9 @@ static int query_memdev(Object *obj, void *opaque)
>
>      return 0;
>  error:
> +    g_free(m->value);
> +    g_free(m);
> +
>      return -1;
>  }
>
> --
> 1.9.3
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]