[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: replace \n with space in optarg
|
From: |
Hu Tao |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: replace \n with space in optarg |
|
Date: |
Mon, 4 Aug 2014 17:29:14 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 04, 2014 at 09:50:20AM +0100, Peter Maydell wrote:
> On 4 August 2014 08:12, Hu Tao <address@hidden> wrote:
> > When optarg happens to contain \n like:
> >
> > ../configure --target-list='i386-softmmu
> > x86_64-softmmu'
> >
> > make will fail with message:
> >
> > config-host.mak:45: *** missing separator. Stop.
>
> Why would you put newlines in the option string? This is
> likely to break for many configure arguments, not just this
> one...
It is not intended but once when I did copy&paste the string it brought a
\n.
>
> I'm a bit dubious about taking this change unless you can
> point to existing practice (eg do autoconf configure scripts
> clean up whitespace like this?)
I doubt there is.
>
> thanks
> -- PMM