Re: [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize

[Paolo Bonzini]

Il 05/08/2014 11:11, Fam Zheng ha scritto:
> DeviceClass->init is the old interface, let's convert scsi devices to the new
> ->realize API.
> 
> A user visible change is the error message shown in qemu-iotests reference
> output, but I don't know what's the best way to retain it. So please review if
> and how this could be improved.

I think the new message is an improvement.

Kevin/Stefan, are you taking both patches or can you alternatively ack
the first?

Paolo

> Fam
> 
> Fam Zheng (2):
>   block: Pass errp in blkconf_geometry
>   scsi-bus: Convert DeviceClass init to realize
> 
>  hw/block/block.c           | 18 +++++-----
>  hw/block/virtio-blk.c      |  7 ++--
>  hw/ide/qdev.c              | 11 ++++--
>  hw/scsi/lsi53c895a.c       |  2 ++
>  hw/scsi/scsi-bus.c         | 64 +++++++++++++++++------------------
>  hw/scsi/scsi-disk.c        | 83 
> +++++++++++++++++++++++++---------------------
>  hw/scsi/scsi-generic.c     | 37 ++++++++++-----------
>  include/hw/block/block.h   |  6 ++--
>  include/hw/scsi/scsi.h     |  7 ++--
>  tests/qemu-iotests/051.out |  4 +--
>  10 files changed, 125 insertions(+), 114 deletions(-)
>