Re: [Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it.

[Eric Blake]

On 07/31/2014 11:27 PM, Benoît Canet wrote:
> Since qmp-command-olds.h is generated from qmp-commands.hx we will sometime 
> want
> to include only a subset of it. For example when linking qapi block commands
> with qemu-nbd.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  Makefile                           |  7 +++
>  scripts/filter_qmp_commands_old.py | 93 
> ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 100 insertions(+)
>  create mode 100755 scripts/filter_qmp_commands_old.py

> +++ b/scripts/filter_qmp_commands_old.py
> @@ -0,0 +1,93 @@
> +#!/usr/bin/env python
> +#
> +# qmp-commands-old.h filtering
> +#
> +# Copyright (C) 2014 Nodalink, EURL.
> +#
> +# Authors:
> +#  Benoit Canet <address@hidden>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2.
> +# See the COPYING file in the top-level directory.

Why GPLv2-only?  New files should prefer GPLv2+ (you should add the "or
later" clause).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature