qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value bef


From: Amos Kong
Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one
Date: Thu, 7 Aug 2014 10:24:12 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Aug 06, 2014 at 03:18:20PM -0300, Eduardo Habkost wrote:
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  backends/rng-egd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/backends/rng-egd.c b/backends/rng-egd.c
> index 25bb3b4..2962795 100644
> --- a/backends/rng-egd.c
> +++ b/backends/rng-egd.c
> @@ -169,6 +169,7 @@ static void rng_egd_set_chardev(Object *obj, const char 
> *value, Error **errp)
>      if (b->opened) {
>          error_set(errp, QERR_PERMISSION_DENIED);
>      } else {
> +        g_free(s->chr_name);
>          s->chr_name = g_strdup(value);
>      }
>  }

Eduardo, a similar patch had been applied.

commit 5e490b6a504912225dff0e520e1c6af68295d238
Author: Amos Kong <address@hidden>
Date:   Thu Nov 21 16:42:50 2013 +0800

    rng-egd: remove redundant free
    
    We didn't set default chr_name, the free is redundant.
    
    Signed-off-by: Amos Kong <address@hidden>
    Message-id: address@hidden
    Signed-off-by: Anthony Liguori <address@hidden>

> -- 
> 1.9.3

-- 
                        Amos.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]