qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 07/10] linux-user: check return value of mall


From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH v3 07/10] linux-user: check return value of malloc()
Date: Fri, 8 Aug 2014 09:21:18 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1

On 2014/8/8 1:19, Richard Henderson wrote:
On 08/06/2014 10:01 PM, zhanghailiang wrote:
      if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
          return -TARGET_EFAULT;
      host_mb = malloc(msgsz+sizeof(long));
+    if (!host_mb) {
+        return -TARGET_ENOMEM;
+    }

lock_user allocates memory; returning from the middle leaks it.


Hmm, it is my fault, i will correct it. Thanks, Richard.

Best regards,
zhanghailiang




reply via email to

[Prev in Thread] Current Thread [Next in Thread]