Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

[Marcelo Tosatti]

On Mon, Aug 04, 2014 at 08:30:48PM +0200, Paolo Bonzini wrote:
> Il 04/08/2014 18:30, Marcin Gibuła ha scritto:
> > 
> > 
> > is this analysis deep enough for you? I don't know if that can be fixed
> > with existing api as cpu_synchronize_all_states() is all or nothing kind
> > of stuff.
> > 
> > Kvmclock needs it only to read current cpu registers, so syncing
> > everything is not really necessary. Perhaps exporting one of
> > kvm_arch_get_* would be enough. And it wouldn't mess with lazy get/put.
> > 
> > On the other hand, if in future any other driver adds
> > cpu_synchronize_all_states() in its change state callback it could
> > result in same error so perhaps more generic approach is needed.
> 
> Yeah, I need to sit down and look at the code more closely...  Perhaps a
> cpu_mark_all_dirty() is enough.

Hi Paolo,

cpu_clean_all_dirty, you mean? Has the same effect.

Marcin's patch to add cpu_synchronize_state_always() has the same
effect.

What do you prefer ?