[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/10] tests/bios-tables-test: check the valu
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/10] tests/bios-tables-test: check the value returned by fopen() |
Date: |
Mon, 11 Aug 2014 10:33:59 +0100 |
zhanghailiang writes:
> The function fopen() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Li Liu <address@hidden>
> ---
> tests/bios-tables-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 045eb27..28ec28d 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -790,6 +790,11 @@ int main(int argc, char *argv[])
> const char *arch = qtest_get_arch();
> FILE *f = fopen(disk, "w");
> int ret;
> +
> + if (f == NULL) {
> + fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno));
> + return -1;
> + }
if (!f) would also be acceptable short-hand.
Reviewed-by: Alex Bennée <address@hidden>
> fwrite(boot_sector, 1, sizeof boot_sector, f);
> fclose(f);
--
Alex Bennée
- [Qemu-devel] [PATCH v5 00/10] fix three bugs about use-after-free and several api abuse, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 04/10] ivshmem: check the value returned by fstat(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 03/10] virtio-blk: fix reference a pointer which might be freed, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 06/10] slirp/misc: Use g_malloc() instead of malloc(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 05/10] util/path: Use the GLib memory allocation routines, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 08/10] tests/bios-tables-test: check the value returned by fopen(), zhanghailiang, 2014/08/11
- Re: [Qemu-devel] [PATCH v5 08/10] tests/bios-tables-test: check the value returned by fopen(),
Alex Bennée <=
- [Qemu-devel] [PATCH v5 02/10] monitor: fix access freed memory, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 01/10] l2cap: fix access freed memory, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 10/10] block/vvfat: fix setbuf stream parameter may be NULL, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 09/10] tcg: check return value of fopen(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 07/10] linux-user: check return value of malloc(), zhanghailiang, 2014/08/11