Re: [Qemu-devel] [PATCH v5 05/10] hw/vfio/pci: split vfio_get_device

[David Gibson]

On Sat, Aug 09, 2014 at 03:25:44PM +0100, Eric Auger wrote:
> vfio_get_device now takes a VFIODevice as argument. The function is split
> into 4 functional parts: dev_info query, device check, region populate
> and interrupt populate. the last 3 are specialized by parent device and
> are added into DeviceOps.

Why is splitting these up into 4 stages useful, rather than having a
single sub-class specific callback?

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpa21NIQ8I4t.pgp
Description: PGP signature