Re: [Qemu-devel] [PATCH 2/2] libqtest: launch QEMU with QEMU_AUDIO_DRV=none

[Andreas Färber]

Am 12.08.2014 14:57, schrieb Markus Armbruster:
> Stefan Hajnoczi <address@hidden> writes:
> 
>> No test case actually uses the audio backend.  Disable audio to prevent
>> errors on hosts with no sound hardware present:
>>
>>   GTESTER check-qtest-aarch64
>>   sdl: SDL_OpenAudio failed
>>   sdl: Reason: No available audio device
>>   sdl: SDL_OpenAudio failed
>>   sdl: Reason: No available audio device
>>   audio: Failed to create voice `lm4549.out'
>>
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>> ---
>>  tests/libqtest.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/libqtest.c b/tests/libqtest.c
>> index 98e8f4b..2abb6f2 100644
>> --- a/tests/libqtest.c
>> +++ b/tests/libqtest.c
>> @@ -165,7 +165,7 @@ QTestState *qtest_init(const char *extra_args)
>>  
>>      s->qemu_pid = fork();
>>      if (s->qemu_pid == 0) {
>> -        command = g_strdup_printf("exec %s "
>> +        command = g_strdup_printf("QEMU_AUDIO_DRV=none exec %s "
>>                                    "-qtest unix:%s,nowait "
>>                                    "-qtest-log /dev/null "
>>                                    "-qmp unix:%s,nowait "
> 
> Gerd (cc'ed) solved this differently in his patch[*].  I'm fine with
> either.

Hm, Gerd's patch seems to only touch audio-specific tests but not the
generic qom-test for instance. What about doing Gerd's setenv() in
Stefan's generic code? Not cluttering the shell call even more would
make it easier to some day convert to an array-based API. Not a priority
though.

Cheers,
Andreas

> [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg03087.html

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg