Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables

[Michael S. Tsirkin]

On Thu, Aug 14, 2014 at 07:53:32PM +0800, Le Tan wrote:
> 2014-08-14 19:51 GMT+08:00 Jan Kiszka <address@hidden>:
> > On 2014-08-14 13:43, Michael S. Tsirkin wrote:
> >> On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote:
> >>> On 2014-08-14 13:06, Michael S. Tsirkin wrote:
> >>>> On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote:
> >>>>> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE 
> >>>>> exists,
> >>>>> add DMAR table to ACPI RSDT table. For now the DMAR table indicates 
> >>>>> that there
> >>>>> is only one hardware unit without INTR_REMAP capability on the platform.
> >>>>>
> >>>>> Signed-off-by: Le Tan <address@hidden>
> >>>>
> >>>> Could you add a unit test please?
> >>>
> >>> While unit tests would really be helpful, I'm afraid that's not in reach
> >>> (GSoC is almost over). The good news is that we have pretty broad test
> >>> coverage with both Linux and also Jailhouse already.
> >>>
> >>> Do you see unit tests as precondition for merging the series?
> >>>
> >>> Jan
> >>>
> >>
> >> Not a pre-requisite - it's very easy to add a unit test,
> >> just add a case in test_acpi_tcg. So I can do it myself afterwards.
> >>
> >
> > Ah, ok, that's tests/bios-tables-test.c. Maybe Le can have a look if
> > time is left. But hard pecils-down is already on the 18th.
> >
> > Jan
> >
> >
> 
> OK, I will attempt to add that. I have just pushed the IOTLB cache. I
> am going to fix patches according to these reviews now.
> 
> Le

Yes, address comments and repost first, tests are nice
to have if you have the time.

-- 
MST