Re: [Qemu-devel] [PATCH v3 07/14] qapi: add some type check tests

[Eric Blake]

On 08/14/2014 03:47 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> Demonstrate that the qapi generator silently parses confusing
>> types, which may cause other errors later on. Later patches
>> will update the expected results as the generator is made stricter.
>>
>> * tests/qapi-schema/data-array-empty.*: New files.
>> * tests/qapi-schema/data-array-unknown.*: Likewise.
>> * tests/qapi-schema/data-unknown.*: Likewise.
>> * tests/qapi-schema/data-int.*: Likewise.
>> * tests/qapi-schema/returns-unknown.*: Likewise.
>> * tests/qapi-schema/returns-int.*: Likewise.
>> * tests/qapi-schema/returns-array-bad.*: Likewise.
>> * tests/Makefile (check-qapi-schema-y): Run them.
>>

>> +++ b/tests/qapi-schema/returns-array-bad.json
>> @@ -0,0 +1 @@
>> +{ 'command': 'oops', 'data': [ 'str', 'str' ] }
> 
> The file name suggests you want to test 'returns' rather than 'data' here.

D'oh.  Definite reason to respin the series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature