[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/12] pci: Use bus master address space for deliveri
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages |
Date: |
Thu, 14 Aug 2014 18:08:44 +0200 |
From: Jan Kiszka <address@hidden>
The spec says (and real HW confirms this) that, if the bus master bit
is 0, the device will not generate any PCI accesses. MSI and MSI-X
messages fall among these, so we should use the corresponding address
space to deliver them. This will prevent delivery if bus master support
is disabled.
Cc: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci/msi.c | 2 +-
hw/pci/msix.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci/msi.c b/hw/pci/msi.c
index a4a3040..52d2313 100644
--- a/hw/pci/msi.c
+++ b/hw/pci/msi.c
@@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector)
"notify vector 0x%x"
" address: 0x%"PRIx64" data: 0x%"PRIx32"\n",
vector, msg.address, msg.data);
- stl_le_phys(&address_space_memory, msg.address, msg.data);
+ stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
}
/* Normally called by pci_default_write_config(). */
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index 5c49bfc..20ae476 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector)
msg = msix_get_message(dev, vector);
- stl_le_phys(&address_space_memory, msg.address, msg.data);
+ stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
}
void msix_reset(PCIDevice *dev)
--
MST
- [Qemu-devel] [PULL 00/12] post-2.1 bugfixes, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 02/12] pc: Create 2.2 machine type, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 04/12] hw:i386: typo fix: MEMORY_HOPTLUG_DEVICE -> MEMORY_HOTPLUG_DEVICE, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 05/12] pc-dimm: validate node property, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 06/12] pc-dimm: fix up error message, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 08/12] acpi: align RSDP, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 09/12] ivshmem: fix building when debug mode is enabled, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 03/12] hw/audio/intel-hda: Fix MSI capability address, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 10/12] e1000: correctly handle phy_ctrl reserved & self-clearing bits, Michael S. Tsirkin, 2014/08/14