[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 3/3] layout: Add generators of L1/L2 tables
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH V4 3/3] layout: Add generators of L1/L2 tables |
|
Date: |
Thu, 14 Aug 2014 21:00:51 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 11, 2014 at 03:01:10PM +0400, Maria Kustova wrote:
> @@ -126,63 +187,59 @@ class Image(object):
> ['>I', 96, 4, 'refcount_order'],
> ['>I', 100, 0, 'header_length']
> ]
> - v_header = FieldsList(meta_header)
> + self.header = FieldsList(meta_header)
Formerly static methods are being changed to regular methods (they take
a 'self' argument). This introduces a lot of noise in the patch.
Please make changes like this in a separate patch so it is easier to
review the L1/L2 table changes in isolation without all the other code
changes.
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpf2QkeBWrdr.pgp
Description: PGP signature