[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/20] vl: don't use 'Yoda conditions'
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 12/20] vl: don't use 'Yoda conditions' |
Date: |
Fri, 15 Aug 2014 19:15:03 +0400 |
From: Gonglei <address@hidden>
imitate nearby code about using '!value' or 'value == NULL'
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index a8029d5..9783133 100644
--- a/vl.c
+++ b/vl.c
@@ -1154,7 +1154,7 @@ static int drive_init_func(QemuOpts *opts, void *opaque)
static int drive_enable_snapshot(QemuOpts *opts, void *opaque)
{
- if (NULL == qemu_opt_get(opts, "snapshot")) {
+ if (qemu_opt_get(opts, "snapshot") == NULL) {
qemu_opt_set(opts, "snapshot", "on");
}
return 0;
@@ -2506,8 +2506,9 @@ static int foreach_device_config(int type, int
(*func)(const char *cmdline))
loc_push_restore(&conf->loc);
rc = func(conf->cmdline);
loc_pop(&conf->loc);
- if (0 != rc)
+ if (rc) {
return rc;
+ }
}
return 0;
}
--
1.7.10.4
- [Qemu-devel] [PULL 02/20] memory: Update obsolete comment about AddrRange field type, (continued)
- [Qemu-devel] [PULL 02/20] memory: Update obsolete comment about AddrRange field type, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 08/20] audio: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 01/20] apic: Fix reported DFR content, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 07/20] usb: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 06/20] CODING_STYLE: Section about conditional statement, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 13/20] vmxnet3: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 19/20] l2cap: fix access to freed memory, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 14/20] qemu-options.hx: fix typo about l2tpv3, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 16/20] ssi: xilinx_spi: Initialise CS GPIOs as NULL, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 20/20] ivshmem: check the value returned by fstat(), Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 12/20] vl: don't use 'Yoda conditions',
Michael Tokarev <=
- [Qemu-devel] [PULL 11/20] spice: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 04/20] pci-host: update obsolete reference about piix_pci.c, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 09/20] isa-bus: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 03/20] qemu-options.hx: fix a typo of chardev, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 05/20] pci-host: update uncorresponding description, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 10/20] don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 18/20] intc: i8259: Convert Array allocation to g_new0, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 17/20] ppc: convert g_new(qemu_irq usages to g_new0, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 15/20] vl: free err, Michael Tokarev, 2014/08/15
- Re: [Qemu-devel] [PULL 00/20] Trivial patches for 2014-08-15, Peter Maydell, 2014/08/18