[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm |
|
Date: |
Fri, 15 Aug 2014 09:54:36 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/11/2014 09:23 AM, Tom Musta wrote:
> +#if defined(TARGET_PPC64)
> + tcg_gen_andi_tl(t0, t0, MASK(32, 63));
> +#endif
Err. this is just simple zero-extension.
> tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], t0);
Why not combine with the mov as
tcg_gen_ext32u_tl
which will just expand to a mov for PPC32.
r~
- [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm, Tom Musta, 2014/08/11
- Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm,
Richard Henderson <=
- [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 4/8] target-ppc: Bug Fix: mullw, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 5/8] target-ppc: Bug Fix: mullwo, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection, Tom Musta, 2014/08/11
- [Qemu-devel] [PATCH 7/8] target-ppc: Bug Fix: srawi, Tom Musta, 2014/08/11