Re: [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw

[Richard Henderson]

On 08/12/2014 03:45 AM, Tom Musta wrote:
> +#else
>      tcg_gen_mul_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)],
>                     cpu_gpr[rB(ctx->opcode)]);
>      tcg_gen_ext32s_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)]);
> +#endif

Note that the sign-extension can be dropped, since this is ifdef PPC32.
Perhaps even better to use tcg_gen_mul_i32 explicitly?  That at least
type-checks the arguments are all 32-bit as well.


r~