Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

[tangchen]

Hi Michael, Paolo

Thanks for the advices. Will send a v2 patch soon.

Thanks.

On 08/19/2014 04:04 AM, Michael S. Tsirkin wrote:
> On Mon, Aug 18, 2014 at 03:58:33PM +0200, Paolo Bonzini wrote:
> > Il 18/08/2014 15:56, Michael S. Tsirkin ha scritto:
> > > > +/* Initialize PCDIMMDevice->node to -1 so that even if user doesn't specify
> > > > + * any numa option, PCDIMMDevice->node won't be 0, which indicates node0.
> > > > + * In this case, SRAT won't be created, and guest kernel will fake a node.
> > > > + */
> > > I think you simply mean
> > > /* default value for PCDIMMDevice->node (unless specified by user) */
> > >
> > > > +#define NO_NODE_ID -1
> > I think a comment about the SRAT would be useful.
> >
> > Paolo
> OK so add:
>
> /* In this case, SRAT won't be created. */
> .