[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/4] qemu-io-cmds: g_renew() can't fail, bury dea
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 3/4] qemu-io-cmds: g_renew() can't fail, bury dead error handling |
Date: |
Tue, 19 Aug 2014 10:31:10 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
---
qemu-io-cmds.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index afd8867..b224ede 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -115,22 +115,13 @@ static char **breakline(char *input, int *count)
int c = 0;
char *p;
char **rval = g_new0(char *, 1);
- char **tmp;
while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
if (!*p) {
continue;
}
c++;
- tmp = g_renew(char *, rval, (c + 1));
- if (!tmp) {
- g_free(rval);
- rval = NULL;
- c = 0;
- break;
- } else {
- rval = tmp;
- }
+ rval = g_renew(char *, rval, (c + 1));
rval[c - 1] = p;
rval[c] = NULL;
}
--
1.9.3
- [Qemu-devel] [PATCH v3 0/4] block: Use g_new() & friends more, Markus Armbruster, 2014/08/19
- [Qemu-devel] [PATCH v3 4/4] block: Drop some superfluous casts from void *, Markus Armbruster, 2014/08/19
- [Qemu-devel] [PATCH v3 2/4] block: Use g_new() & friends to avoid multiplying sizes, Markus Armbruster, 2014/08/19
- [Qemu-devel] [PATCH v3 3/4] qemu-io-cmds: g_renew() can't fail, bury dead error handling,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 1/4] block: Use g_new() & friends where that makes obvious sense, Markus Armbruster, 2014/08/19
- Re: [Qemu-devel] [PATCH v3 0/4] block: Use g_new() & friends more, Kevin Wolf, 2014/08/19