Re: [Qemu-devel] [PATCH 0/4] Convert remaining legacy chardevs to parse/kind

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> This patchset converts the two remaining legacy chardevs
> ('socket' and 'udp') to use the new-style parse/kind
> mechanisms, and removes all the no-longer-required
> legacy machinery.
>
> Patch 1 was posted to the list back in June
> (https://patches.linaro.org/32298/). I've fixed the obvious
> bug picked up in code review, and as far as I can tell from
> the thread we decided that the blocking/non-blocking
> difference between QAPI and legacy wasn't a problem.
>
> Patch 2 fixes a hole in the functionality of QAPI-described
> UDP chardevs, to avoid regressing the commandline functionality
> when we convert the UDP backend in patch 3.
>
> Patch 4 may be easier to review as an ignore-whitespaces
> diff (the de-indentation makes the diff a bit awkward).

Thanks a lot for finishing this job.

I had a few remarks, and you might want to address them.  But even in
its current state, the series is an improvement, therefore:

Reviewed-by: Markus Armbruster <address@hidden>