Re: [Qemu-devel] [PULL v2 00/23] linux-user updates

[Riku Voipio]

On 19 August 2014 14:59, Peter Maydell <address@hidden> wrote:
> Hi. I'm afraid this doesn't build on my ARM board:
>
> /root/qemu/linux-user/syscall.c: In function 'do_open_by_handle_at':
> /root/qemu/linux-user/syscall.c:5475:16: error: 'p' may be used
> uninitialized in this function [-Werror=uninitialized]

> The compiler seems to be correct here -- we should
> be passing 'fh' to unlock_user(), not 'p' (which seems
> to be completely useless and should be deleted).

rat. I wonder how your older gcc on arm catches these regularly while
the brand new gcc 4.9.1 from debian doesn't.

> This function and name_to_handle_at() also both seem
> to be missing the necessary guest-to-host byteswaps
> on the fields in struct file_handle.

ack, will fix.

Riku