[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check |
|
Date: |
Tue, 19 Aug 2014 16:03:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 19/08/2014 15:50, Peter Crosthwaite ha scritto:
> So I'm curious to know if and how this manifested for you as a bug?
> Can you reproduce this as a bug somehow even as a memory leak? as the
> only way I can see local_err getting populated is a fail of:
>
> object_property_add_child(container_get(qdev_get_machine(),
> "/unattached"),
> name, obj, &local_err);
>
> Which, if fails indicates something very wrong. Should we promote that
> fail to &error_abort and just drop the local_err logic entirely? I'm
> very interested on your replication conditions on this one.
Yes, I don't think it can happen. The user can only refer to
/machine/peripheral, not /machine/unattached. &error_abort is better.
Paolo
- [Qemu-devel] [PATCH 3/3] pcie: using error_setg instead of impolite assert, (continued)