qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 10/10] hw/arm/dyn_sysbus_devtree: enable simp


From: Joel Schopp
Subject: Re: [Qemu-devel] [PATCH v5 10/10] hw/arm/dyn_sysbus_devtree: enable simple VFIO dynamic instantiation
Date: Tue, 19 Aug 2014 09:15:54 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

>> For the index [2*i],[2*i+1], etc is clearly a bug as when i = 1 it will
>> overwrite two of the values.  Changing that to [4*i],[4*i+1],etc fixes it.
>>
>> I think you are right on the size.  I also wonder if the user doesn't
>> pass in a dtb if qemu should try to recreate the device-tree entry from
>> the platform device entry in the host kernel?  If so would that best be
>> done by recreating the values from /proc/device-tree ?
>>
>> I also wish that qemu had a flag to output the generated dtb to a file
>> much like lkvm (kvmtool) has.
> It does. "qemu-system-foo -machine dumpdtb=mydtb.dtb" should dump the
> generated dtb into a file called mydtb.dtb.

Would a patch that adds this output to --help be welcomed?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]