[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices |
Date: |
Tue, 19 Aug 2014 17:45:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 04.08.2014 13:45, schrieb Amit Shah:
>> On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote:
>>> Amit Shah <address@hidden> writes:
>>>
>>>> To ensure two virtserialports don't get added to the system with the
>>>> same 'name' parameter, we need to access all the ports on all the
>>>> devices added, and compare the names.
>>>>
>>>> We currently don't have a list of all VirtIOSerial devices added to the
>>>> system. This commit adds a simple linked list in which devices are put
>>>> when they're initialized, and removed when they go away.
> [...]
>>> Patch looks simple & safe to me, but I can't help to wonder whether want
>>> (or already have?) more generic infrastructure offering "for all devices
>>> of a certain kind" functionality, which is what 2/2 needs. Andreas?
>>
>> Yea; I didn't find any, but if there's already something it can be put
>> to good use here.
>
> If you're looking for devices of the same QOM type, that can be done
> through some QOM path syntax that Paolo introduced. Someone used it in a
> recent iommu series.
Possibly
object_class_foreach(fn, TYPE_VIRTIO_SERIAL_PORT, false, false, arg);