Re: [Qemu-devel] [PATCH 0/6] block: Let drivers reconstruct the filename

[Kevin Wolf]

Am 18.07.2014 um 20:24 hat Max Reitz geschrieben:
> We may sometimes want a filename for BDSs which do not have one because
> they weren't opened using a simple filename (but rather just through
> options, for example).
> 
> Some block drivers are always capable of reconstructing a valid filename
> (e.g. NBD), even if the BDS has been opened using the options QDict
> only. For others (e.g. Quorum) this is impossible. To accommodate this
> case, the function which reconstructs ("refreshes") the filename for a
> BDS also generates an options QDict (which should always work). If some
> layer cannot generate a plain filename (e.g. a Quorum instance), we can
> still generate a QDict which contains all options necessary for opening
> the block device in (basically) the same state.
> 
> If a filename can be generated, the one stored in the BDS is
> overwritten. Otherwise, the QDict is converted to JSON, prefixed with
> "json:" and then used as the filename (making use of the JSON
> pseudo-protocol).
> 
> 
> Block drivers which probably need to implement bdrv_refresh_filename()
> besides blkdebug, blkverify, NBD and Quorum but which this series does
> not cover, are the following: curl, ssh and vvfat.

Thanks, applied all to the block branch.

I don't think we're done yet. This series leads to some strange looking
things both in the source and in the output. I merged it anyway because
I think it does provide some value and we can fix the problems
incrementally.

Kevin