[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state |
Date: |
Wed, 20 Aug 2014 18:47:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Lluís Vilanova <address@hidden> writes:
> Also removes old "trace-event", "trace-file" and "info trace-events" HMP
> commands.
We gain the ability to control trace via QMP, but lose the ability to
control it via HMP, correct?
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> hmp-commands.hx | 35 -----------------------
> monitor.c | 61 ----------------------------------------
> qapi-schema.json | 3 ++
> qmp-commands.hx | 27 ++++++++++++++++++
> trace/Makefile.objs | 1 +
> trace/commands.json | 44 +++++++++++++++++++++++++++++
There's no precedence for keeping schema bits anywhere but in qapi/.
If we decide we want to keep them with their related C parts instead, we
should do so consistently, not just for trace.
> trace/control.c | 13 ---------
> trace/control.h | 7 -----
> trace/qmp.c | 77
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> trace/simple.c | 10 +------
> trace/simple.h | 3 --
> 11 files changed, 154 insertions(+), 127 deletions(-)
> create mode 100644 trace/commands.json
> create mode 100644 trace/qmp.c
[...]