Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

[Lluís Vilanova]

Markus Armbruster writes:

> Lluís Vilanova <address@hidden> writes:
>> Also removes old "trace-event", "trace-file" and "info trace-events" HMP
>> commands.

> We gain the ability to control trace via QMP, but lose the ability to
> control it via HMP, correct?

Right. I can keep the HMP commands, but doing so requires exposing the internal
trace event identifier number in the QMP interface. Also, "trace-file" cannot be
implemented on top of the current QMP commands, and is specific to the "simple"
tracing backend.


>> 
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> hmp-commands.hx     |   35 -----------------------
>> monitor.c           |   61 ----------------------------------------
>> qapi-schema.json    |    3 ++
>> qmp-commands.hx     |   27 ++++++++++++++++++
>> trace/Makefile.objs |    1 +
>> trace/commands.json |   44 +++++++++++++++++++++++++++++

> There's no precedence for keeping schema bits anywhere but in qapi/.
> If we decide we want to keep them with their related C parts instead, we
> should do so consistently, not just for trace.

Ok, I'll move it to qapi.


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth