qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions
Date: Wed, 20 Aug 2014 13:15:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0

On 08/20/2014 11:59 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  scripts/qapi-types.py | 2 ++
>  scripts/qapi-visit.py | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

(On a tangentially related note, I'd still like to get to the point
where we can have a 'discriminator' in a union even without a 'base' -
the fact that flat unions are typesafe but old-style unions are not is a
bit annoying)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]