[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object |
|
Date: |
Thu, 21 Aug 2014 11:02:49 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 08/20 15:29, Paolo Bonzini wrote:
> Il 20/08/2014 12:01, Fam Zheng ha scritto:
> > +
> > +qemuutil.o: CC_REL_FLAGS := -Wl,-r
>
> Why the target-specific rule?
>
> > +qemuutil.o: $(util-obj-y)
> > + $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^," LD -r
> > $(TARGET_DIR)$@")
> >
>
>
> I think either you have
>
> LD_REL := $(CC) -nostdlib -Wl,-r
>
> (as opposed to "LD_REL := $(LD) -r" for example) or you do not need to
> put -Wl,-r in a separate variable.
Because comma doesn't work in Makefile macro invocation, we need to wrap the
flag in a variable. (Is there a way to escape it?) Your LD_REL looks cleaner
though.
Fam
- Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util, (continued)
[Qemu-devel] [PATCH 4/6] stubs: Add timer.c, Fam Zheng, 2014/08/20
[Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/, Fam Zheng, 2014/08/20
[Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object, Fam Zheng, 2014/08/20
[Qemu-devel] [PATCH 3/6] stubs: Add openpty.c, Fam Zheng, 2014/08/20
[Qemu-devel] [PATCH 2/6] stubs: Add iohandler.c, Fam Zheng, 2014/08/20