[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pcie: Fix incorrect write to device ctl2 regist
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] pcie: Fix incorrect write to device ctl2 register |
|
Date: |
Thu, 21 Aug 2014 10:58:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 21/08/2014 10:31, address@hidden ha scritto:
> +++ b/hw/pci/pcie.c
> @@ -504,7 +504,7 @@ void pcie_cap_ari_init(PCIDevice *dev)
> uint32_t pos = dev->exp.exp_cap;
> pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCAP2,
> PCI_EXP_DEVCAP2_ARI);
> - pci_long_test_and_set_mask(dev->wmask + pos + PCI_EXP_DEVCTL2,
> + pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCTL2,
> PCI_EXP_DEVCTL2_ARI);
> }
>
IIUC the code is correct, it means that the bit can be written in
devctl2. You don't want to set it, the firmware or OS can do it if they
understand ARI.
Paolo