Re: [Qemu-devel] [PATCH] pcie: Fix incorrect write to device ctl2 register

[Gonglei (Arei)]

> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo
> Bonzini
> Sent: Thursday, August 21, 2014 4:59 PM
> To: Gonglei (Arei); address@hidden
> Cc: Huangweidong (C); address@hidden; address@hidden;
> address@hidden
> Subject: Re: [PATCH] pcie: Fix incorrect write to device ctl2 register
> 
> Il 21/08/2014 10:31, address@hidden ha scritto:
> > +++ b/hw/pci/pcie.c
> > @@ -504,7 +504,7 @@ void pcie_cap_ari_init(PCIDevice *dev)
> >      uint32_t pos = dev->exp.exp_cap;
> >      pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCAP2,
> >                                 PCI_EXP_DEVCAP2_ARI);
> > -    pci_long_test_and_set_mask(dev->wmask + pos + PCI_EXP_DEVCTL2,
> > +    pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCTL2,
> >                                 PCI_EXP_DEVCTL2_ARI);
> >  }
> >
> 
> IIUC the code is correct, it means that the bit can be written in
> devctl2.  You don't want to set it, the firmware or OS can do it if they
> understand ARI.
> 
> Paolo

Oh, yes. You are right. 

Forgot the noise pls, thanks! 

Best regards,
-Gonglei